[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 15/20] linux-user: Add support for FD<SETEMSGTRESH|SETMAXE
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v5 15/20] linux-user: Add support for FD<SETEMSGTRESH|SETMAXERRS|GETMAXERRS> ioctls |
Date: |
Tue, 14 Jan 2020 15:36:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
Le 13/01/2020 à 21:34, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
>
> FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls are commands
> for controlling error reporting of a floppy drive.
>
> FDSETEMSGTRESH's third agrument is a pointer to the structure:
>
> struct floppy_max_errors {
> unsigned int
> abort, /* number of errors to be reached before aborting */
> read_track, /* maximal number of errors permitted to read an
> * entire track at once */
> reset, /* maximal number of errors before a reset is tried */
> recal, /* maximal number of errors before a recalibrate is
> * tried */
> /*
> * Threshold for reporting FDC errors to the console.
> * Setting this to zero may flood your screen when using
> * ultra cheap floppies ;-)
> */
> reporting;
> };
>
> defined in Linux kernel header <linux/fd.h>.
>
> Since all fields of the structure are of type 'unsigned int', there is
> no need to define "target_floppy_max_errors".
>
> FDSETMAXERRS and FDGETMAXERRS ioctls do not use the third argument.
>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> linux-user/ioctls.h | 3 +++
> linux-user/syscall_defs.h | 3 +++
> linux-user/syscall_types.h | 7 +++++++
> 3 files changed, 13 insertions(+)
>
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index 66f8c4e..9e3ca90 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -114,7 +114,10 @@
>
> IOCTL(FDMSGON, 0, TYPE_NULL)
> IOCTL(FDMSGOFF, 0, TYPE_NULL)
> + IOCTL(FDSETEMSGTRESH, 0, TYPE_NULL)
> IOCTL(FDFLUSH, 0, TYPE_NULL)
> + IOCTL(FDSETMAXERRS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_floppy_max_errors)))
> + IOCTL(FDGETMAXERRS, IOC_R, MK_PTR(MK_STRUCT(STRUCT_floppy_max_errors)))
> IOCTL(FDRESET, 0, TYPE_NULL)
> IOCTL(FDRAWCMD, 0, TYPE_NULL)
> IOCTL(FDTWADDLE, 0, TYPE_NULL)
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index 6b88030..efe3860 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -899,7 +899,10 @@ struct target_pollfd {
>
> #define TARGET_FDMSGON TARGET_IO(2, 0x45)
> #define TARGET_FDMSGOFF TARGET_IO(2, 0x46)
> +#define TARGET_FDSETEMSGTRESH TARGET_IO(2, 0x4a)
> #define TARGET_FDFLUSH TARGET_IO(2, 0x4b)
> +#define TARGET_FDSETMAXERRS TARGET_IOW(2, 0x4c, struct floppy_max_errors)
> +#define TARGET_FDGETMAXERRS TARGET_IOR(2, 0x0e, struct floppy_max_errors)
> #define TARGET_FDRESET TARGET_IO(2, 0x54)
> #define TARGET_FDRAWCMD TARGET_IO(2, 0x58)
> #define TARGET_FDTWADDLE TARGET_IO(2, 0x59)
> diff --git a/linux-user/syscall_types.h b/linux-user/syscall_types.h
> index 4e36983..e4e0429 100644
> --- a/linux-user/syscall_types.h
> +++ b/linux-user/syscall_types.h
> @@ -261,6 +261,13 @@ STRUCT(blkpg_ioctl_arg,
> TYPE_INT, /* datalen */
> TYPE_PTRVOID) /* data */
>
> +STRUCT(floppy_max_errors,
> + TYPE_INT, /* abort */
> + TYPE_INT, /* read_track */
> + TYPE_INT, /* reset */
> + TYPE_INT, /* recal */
> + TYPE_INT) /* reporting */
> +
> #if defined(CONFIG_USBFS)
> /* usb device ioctls */
> STRUCT(usbdevfs_ctrltransfer,
>
Reviewed-by: Laurent Vivier <address@hidden>
- Re: [PATCH v5 09/20] linux-user: Add support for FS_IOC_<GET|SET>VERSION ioctls, (continued)
- [PATCH v5 12/20] linux-user: Add support for FS_IOC_FS<GET|SET>XATTR ioctls, Aleksandar Markovic, 2020/01/13
- [PATCH v5 11/20] linux-user: Add support for FS_IOC32_<GET|SET>VERSION ioctls, Aleksandar Markovic, 2020/01/13
- [PATCH v5 14/20] linux-user: Add support for FIFREEZE and FITHAW ioctls, Aleksandar Markovic, 2020/01/13
- [PATCH v5 13/20] linux-user: Add support for FITRIM ioctl, Aleksandar Markovic, 2020/01/13
- [PATCH v5 15/20] linux-user: Add support for FD<SETEMSGTRESH|SETMAXERRS|GETMAXERRS> ioctls, Aleksandar Markovic, 2020/01/13
- Re: [PATCH v5 15/20] linux-user: Add support for FD<SETEMSGTRESH|SETMAXERRS|GETMAXERRS> ioctls,
Laurent Vivier <=
- [PATCH v5 16/20] linux-user: Add support for FDFMT<BEG|TRK|END> ioctls, Aleksandar Markovic, 2020/01/13
- [PATCH v5 17/20] linux-user: Add support for FDGETFDCSTAT ioctl, Aleksandar Markovic, 2020/01/13
- [PATCH v5 19/20] linux-user: Add support for KCOV_<ENABLE|DISABLE> ioctls, Aleksandar Markovic, 2020/01/13
- [PATCH v5 18/20] configure: Detect kcov support and introduce CONFIG_KCOV, Aleksandar Markovic, 2020/01/13
- [PATCH v5 20/20] linux-user: Add support for KCOV_INIT_TRACE ioctl, Aleksandar Markovic, 2020/01/13