Re: [PULL 00/29] Migration pull patches (second try)

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/29] Migration pull patches (second try)
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
0c3394b migration: Support QLIST migration
9f8433e apic: Use 32bit APIC ID for migration instance ID
b29c843 migration: Change SaveStateEntry.instance_id into uint32_t
efd00fa migration: Define VMSTATE_INSTANCE_ID_ANY
c9e615f Bug #1829242 correction.
90e17af migration/multifd: fix destroyed mutex access in terminating multifd 
threads
40d8962 migration/multifd: fix nullptr access in terminating multifd threads
3291d93 migration/multifd: not use multifd during postcopy
ac5f0e5 migration/multifd: clean pages after filling packet
3f9f3e0 migration/postcopy: enable compress during postcopy
b533fd6 migration/postcopy: enable random order target page arrival
51a912d migration/postcopy: set all_zero to true on the first target page
1d79640 migration/postcopy: count target page number to decide the place_needed
1bb0660 migration/postcopy: wait for decompress thread in precopy
2d9ee73 migration/postcopy: reduce memset when it is zero page and 
matches_target_page_size
1656129 migration/ram: Yield periodically to the main loop
34e9a27 migration: savevm_state_handler_insert: constant-time element insertion
eecc4fb migration: add savevm_state_handler_remove()
5eaf803 misc: use QEMU_IS_ALIGNED
1262d9d migration: Fix the re-run check of the migrate-incoming command
bda9064 migration: Fix incorrect integer->float conversion caught by clang
af366d8 migration: Rate limit inside host pages
b70f326 ram.c: remove unneeded labels
076fa7c runstate: ignore finishmigrate -> prelaunch transition
139b217 migration-test: ppc64: fix FORTH test program
f821049 migration-test: introduce functions to handle string parameters
70de133 migration: Make sure that we don't call write() in case of error
397caec migration-test: Add migration multifd test
9a898ef multifd: Initialize local variable

=== OUTPUT BEGIN ===
1/29 Checking commit 9a898efa8cdd (multifd: Initialize local variable)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 8 lines checked

Patch 1/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/29 Checking commit 397caec25c6d (migration-test: Add migration multifd test)
3/29 Checking commit 70de13354cf7 (migration: Make sure that we don't call 
write() in case of error)
4/29 Checking commit f8210496ba76 (migration-test: introduce functions to 
handle string parameters)
5/29 Checking commit 139b217960ef (migration-test: ppc64: fix FORTH test 
program)
6/29 Checking commit 076fa7cc767e (runstate: ignore finishmigrate -> prelaunch 
transition)
7/29 Checking commit b70f326cad3e (ram.c: remove unneeded labels)
8/29 Checking commit af366d8d4aa3 (migration: Rate limit inside host pages)
9/29 Checking commit bda906418d94 (migration: Fix incorrect integer->float 
conversion caught by clang)
10/29 Checking commit 1262d9df6af7 (migration: Fix the re-run check of the 
migrate-incoming command)
11/29 Checking commit 5eaf8034e18e (misc: use QEMU_IS_ALIGNED)
12/29 Checking commit eecc4fb12fe4 (migration: add 
savevm_state_handler_remove())
13/29 Checking commit 34e9a27c5352 (migration: savevm_state_handler_insert: 
constant-time element insertion)
14/29 Checking commit 165612933a8a (migration/ram: Yield periodically to the 
main loop)
15/29 Checking commit 2d9ee73dc120 (migration/postcopy: reduce memset when it 
is zero page and matches_target_page_size)
16/29 Checking commit 1bb06608be50 (migration/postcopy: wait for decompress 
thread in precopy)
17/29 Checking commit 1d7964001e43 (migration/postcopy: count target page 
number to decide the place_needed)
18/29 Checking commit 51a912d14296 (migration/postcopy: set all_zero to true on 
the first target page)
19/29 Checking commit b533fd62c4f2 (migration/postcopy: enable random order 
target page arrival)
20/29 Checking commit 3f9f3e010fc0 (migration/postcopy: enable compress during 
postcopy)
21/29 Checking commit ac5f0e5b4216 (migration/multifd: clean pages after 
filling packet)
22/29 Checking commit 3291d939accf (migration/multifd: not use multifd during 
postcopy)
23/29 Checking commit 40d8962c5339 (migration/multifd: fix nullptr access in 
terminating multifd threads)
24/29 Checking commit 90e17aff65e2 (migration/multifd: fix destroyed mutex 
access in terminating multifd threads)
25/29 Checking commit c9e615f603c9 (Bug #1829242 correction.)
26/29 Checking commit efd00face1e8 (migration: Define VMSTATE_INSTANCE_ID_ANY)
27/29 Checking commit b29c84322acc (migration: Change 
SaveStateEntry.instance_id into uint32_t)
28/29 Checking commit 9f8433e74628 (apic: Use 32bit APIC ID for migration 
instance ID)
29/29 Checking commit 0c3394b08365 (migration: Support QLIST migration)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden