qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] linux-user: remove gemu_log from the linux-user tree


From: Alex Bennée
Subject: Re: [PATCH 3/4] linux-user: remove gemu_log from the linux-user tree
Date: Tue, 14 Jan 2020 10:56:28 +0000
User-agent: mu4e 1.3.6; emacs 28.0.50

Josh Kunz <address@hidden> writes:

> Now that all uses have been migrated to `qemu_log' it is no longer
> needed.
>
> Signed-off-by: Josh Kunz <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  linux-user/main.c | 9 ---------
>  linux-user/qemu.h | 1 -
>  2 files changed, 10 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 0bf40c4d27..945b6adf3a 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -108,15 +108,6 @@ const char *qemu_uname_release;
>     by remapping the process stack directly at the right place */
>  unsigned long guest_stack_size = 8 * 1024 * 1024UL;
>  
> -void gemu_log(const char *fmt, ...)
> -{
> -    va_list ap;
> -
> -    va_start(ap, fmt);
> -    vfprintf(stderr, fmt, ap);
> -    va_end(ap);
> -}
> -
>  #if defined(TARGET_I386)
>  int cpu_get_pic_interrupt(CPUX86State *env)
>  {
> diff --git a/linux-user/qemu.h b/linux-user/qemu.h
> index 02c6890c8a..329b409e65 100644
> --- a/linux-user/qemu.h
> +++ b/linux-user/qemu.h
> @@ -210,7 +210,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>                      abi_long arg2, abi_long arg3, abi_long arg4,
>                      abi_long arg5, abi_long arg6, abi_long arg7,
>                      abi_long arg8);
> -void gemu_log(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
>  extern __thread CPUState *thread_cpu;
>  void cpu_loop(CPUArchState *env);
>  const char *target_strerror(int err);


-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]