[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 03/12] migration: Create the multi-rdma-channels paramete
From: |
Markus Armbruster |
Subject: |
Re: [PATCH RFC 03/12] migration: Create the multi-rdma-channels parameter |
Date: |
Mon, 13 Jan 2020 16:34:46 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Zhimin Feng <address@hidden> writes:
> From: fengzhimin <address@hidden>
>
> Indicates the number of RDMA threads that we would create.
> By default we create 2 threads for RDMA migration.
>
> Signed-off-by: fengzhimin <address@hidden>
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json
> index c995ffdc4c..ab79bf0600 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -588,6 +588,10 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # Defaults to 99. (Since 3.1)
> #
> +# @multi-rdma-channels: Number of channels used to migrate data in
> +# parallel. This is the same number that the
same number as
> +# number of multiRDMA used for migration. The
Pardon my ignorance: what's "the number of multiRDMA used for
migration"?
> +# default value is 2 (since 4.2)
(since 5.0)
> # Since: 2.4
> ##
> { 'enum': 'MigrationParameter',
> @@ -600,7 +604,8 @@
> 'downtime-limit', 'x-checkpoint-delay', 'block-incremental',
> 'multifd-channels',
> 'xbzrle-cache-size', 'max-postcopy-bandwidth',
> - 'max-cpu-throttle' ] }
> + 'max-cpu-throttle',
> + 'multi-rdma-channels'] }
>
> ##
> # @MigrateSetParameters:
> @@ -690,6 +695,10 @@
> # @max-cpu-throttle: maximum cpu throttle percentage.
> # The default value is 99. (Since 3.1)
> #
> +# @multi-rdma-channels: Number of channels used to migrate data in
> +# parallel. This is the same number that the
> +# number of multiRDMA used for migration. The
> +# default value is 2 (since 4.2)
See above.
> # Since: 2.4
> ##
> # TODO either fuse back into MigrationParameters, or make
> @@ -715,7 +724,8 @@
> '*multifd-channels': 'int',
> '*xbzrle-cache-size': 'size',
> '*max-postcopy-bandwidth': 'size',
> - '*max-cpu-throttle': 'int' } }
> + '*max-cpu-throttle': 'int',
Please use spaces instead of tab.
> + '*multi-rdma-channels': 'int'} }
>
> ##
> # @migrate-set-parameters:
> @@ -825,6 +835,10 @@
> # Defaults to 99.
> # (Since 3.1)
> #
> +# @multi-rdma-channels: Number of channels used to migrate data in
> +# parallel. This is the same number that the
> +# number of multiRDMA used for migration. The
> +# default value is 2 (since 4.2)
> # Since: 2.4
See above.
> ##
> { 'struct': 'MigrationParameters',
> @@ -847,8 +861,9 @@
> '*block-incremental': 'bool' ,
> '*multifd-channels': 'uint8',
> '*xbzrle-cache-size': 'size',
> - '*max-postcopy-bandwidth': 'size',
> - '*max-cpu-throttle':'uint8'} }
> + '*max-postcopy-bandwidth': 'size',
> + '*max-cpu-throttle':'uint8',
> + '*multi-rdma-channels':'uint8'} }
>
> ##
> # @query-migrate-parameters:
Please use spaces instead of tab.
- [PATCH RFC 00/12] *** mulitple RDMA channels for migration ***, Zhimin Feng, 2020/01/09
- [PATCH RFC 08/12] migration/rdma: register memory for multiRDMA channels, Zhimin Feng, 2020/01/09
- [PATCH RFC 03/12] migration: Create the multi-rdma-channels parameter, Zhimin Feng, 2020/01/09
- [PATCH RFC 09/12] migration/rdma: Wait for all multiRDMA to complete registration, Zhimin Feng, 2020/01/09
- [PATCH RFC 04/12] migration/rdma: Create multiRDMA migration threads, Zhimin Feng, 2020/01/09
- [PATCH RFC 06/12] migration/rdma: Transmit initial package, Zhimin Feng, 2020/01/09
- [PATCH RFC 11/12] migration/rdma: use multiRDMA to send RAM block for NOT rdma-pin-all mode, Zhimin Feng, 2020/01/09
- [PATCH RFC 01/12] migration: Add multiRDMA capability support, Zhimin Feng, 2020/01/09