Re: [PATCH 10/21] hw/core: Fix latent fit_load_fdt() error handling bug

[Markus Armbruster]

Vladimir Sementsov-Ogievskiy <address@hidden> writes:

> 06.12.2019 13:53, Vladimir Sementsov-Ogievskiy wrote:
>> 06.12.2019 10:46, Markus Armbruster wrote:
>>> Vladimir Sementsov-Ogievskiy <address@hidden> writes:
[...]
>>>> So much attention to that function :)
>>>>
>>>> I'd also propose the following:
[...]
>>>
>>> Looks like a sensible separate cleanup patch to me.  Care to post it?
>>>
>> 
>> Yes, I'll send
>> 
>
>
> Hm, it doesn't compile, as fit_load_image_alloc return type is const pointer..
> So, I just don't understand the logic of the code (for me it's strange to
> free pointer, returned by function, returning const pointer)
>
> And what are the reasons, to make return type of fit_load_image_alloc 
> constant,
> I don't see.. IMHO, there are no reasons.
> Same thing with .fdt_filter ...
>
> I don't want to dig in, so, sorry, I'll not send :)

That's okay.