|
From: | Daniel Henrique Barboza |
Subject: | Re: [PATCH v1 37/59] s390x/event-facility.c: remove unneeded labels |
Date: | Wed, 8 Jan 2020 11:15:14 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 |
On 1/8/20 9:46 AM, Cornelia Huck wrote:
On Mon, 6 Jan 2020 15:24:03 -0300 Daniel Henrique Barboza <address@hidden> wrote:
[..]
I think read_event_data() is still a bit confusing, even if we get rid of the 'out:' label, as the flow remains the same. How about something like the following, which makes it clear that we handle the sccb events for unconditional read and for a selective read with a valid mask:
The code reading is better with your suggestion indeed. I'll re-send this patch with this new read_event_data() flow. Thanks, DHB
[Prev in Thread] | Current Thread | [Next in Thread] |