[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] migration/ram: Yield periodically to the main loop
From: |
Juan Quintela |
Subject: |
Re: [PATCH v2] migration/ram: Yield periodically to the main loop |
Date: |
Wed, 08 Jan 2020 14:32:54 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Juan Quintela <address@hidden> wrote:
> Yury Kotov <address@hidden> wrote:
>> Usually, incoming migration coroutine yields to the main loop
>> while its IO-channel is waiting for data to receive. But there is a case
>> when RAM migration and data receive have the same speed: VM with huge
>> zeroed RAM. In this case, IO-channel won't read and thus the main loop
>> is stuck and for instance, it doesn't respond to QMP commands.
>>
>> For this case, yield periodically, but not too often, so as not to
>> affect the speed of migration.
>>
>> Signed-off-by: Yury Kotov <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
Nack.
The idea is good. But it fails migration-test to fail from time to time
(50% of the time on my laptop).
Will investigate why this is failing.
Later, Juan.