Re: [PATCH v7] qga: add command guest-get-devices for reporting VirtIO devices

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v7] qga: add command guest-get-devices for reporting VirtIO 
devices
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
f811ce5 qga: add command guest-get-devices for reporting VirtIO devices

=== OUTPUT BEGIN ===
ERROR: space required after that ',' (ctx:VxV)
#250: FILE: qga/commands-win32.c:2395:
+            device->address = g_new0(GuestDeviceAddress,1);
                                                        ^

total: 1 errors, 0 warnings, 312 lines checked

Commit f811ce5a32d3 (qga: add command guest-get-devices for reporting VirtIO 
devices) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden