Re: [PATCH v2 8/8] pc: stubify x86 iommu

[Thomas Huth]

On 07/01/2020 15.26, Thomas Huth wrote:
> On 12/12/2019 18.29, Paolo Bonzini wrote:
>> Allow building microvm without x86-iommu.c and in turn hw/i386/pc.h.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>  hw/i386/Kconfig          |  6 ++++++
>>  hw/i386/Makefile.objs    |  3 ++-
>>  hw/i386/x86-iommu-stub.c | 34 ++++++++++++++++++++++++++++++++++
>>  3 files changed, 42 insertions(+), 1 deletions(-)
>>  create mode 100644 hw/i386/x86-iommu-stub.c
> 
> I just ran into this strange Travis build issue:
> 
>  https://travis-ci.com/huth/qemu/jobs/273007378#L3509
> 
> ... I think it might be related to this patch?
> 
> CONFIG_Q35 only does "imply AMD_IOMMU", so when compiling with
> "--without-default-devices", x86-iommu.c is not used... Do
> x86_iommu_ir_supported() and x86_iommu_get_type() need to be added to
> the x86-iommu-stub.c file?

FWIW, I just found Phil's patch which should fix this issue:

https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg00959.html

 Thomas