[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/7] configure: Do not force pie=no for non-x86

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 3/7] configure: Do not force pie=no for non-x86
Date: Tue, 7 Jan 2020 12:37:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/18/19 11:34 PM, Richard Henderson wrote:
PIE is supported on many other hosts besides x86.

The default for non-x86 is now the same as x86: pie is used
if supported, and may be forced via --enable/--disable-pie.

The original commit (40d6444e91c) said:

   "Non-x86 are not changed, as they require TCG changes"

but I think that's wrong -- there's nothing about PIE that
affects TCG one way or another.

Tested on aarch64 (bionic) and ppc64le (centos 7) hosts.

Signed-off-by: Richard Henderson <address@hidden>
  configure | 10 ----------
  1 file changed, 10 deletions(-)

diff --git a/configure b/configure
index 30e3875c6b..99faf64a74 100755
--- a/configure
+++ b/configure
@@ -2018,16 +2018,6 @@ if ! compile_prog "-Werror" "" ; then
        "Thread-Local Storage (TLS). Please upgrade to a version that does."
-if test "$pie" = ""; then
-  case "$cpu-$targetos" in
-    i386-Linux|x86_64-Linux|x32-Linux|i386-OpenBSD|x86_64-OpenBSD)
-      ;;
-    *)
-      pie="no"
-      ;;
-  esac
  if test "$pie" != "no" ; then
    cat > $TMPC << EOF

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]