Re: [PATCH v3 2/4] RISC-V: configure and turn on vector extension from command line

[LIU Zhiwei]

On 2020/1/7 5:48, Jim Wilson wrote:

> On
>       1/2/20 7:33 PM, LIU Zhiwei wrote:
>       
> > +            if (cpu->cfg.vlen >
> >         RV_VLEN_MAX) {
> >         
> >         +                error_setg(errp,
> >         
> >         +                       "Vector extension VLEN must <= %d",
> >         RV_VLEN_MAX);
> >         
> >         +                return;
> >         
> >       
>       
>       There is no architectural maximum for VLEN.  This is simply an
>       implementation choice so you can use static arrays instead of
>       malloc.  I think this error should be reworded to something like
>       "Vector extension implementation only supports VLEN <= %d."
>       
>        
>     
    Thanks. It's good to reduce ambiguous.
    Zhiwei
    
> The
>       other errors here are for architecture requirements and are OK.
>       
>       
>       Jim
>       
>