[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/iothread: Always connect iothread GSource to a GMainCo

From: Peter Xu
Subject: Re: [PATCH] tests/iothread: Always connect iothread GSource to a GMainContext
Date: Mon, 6 Jan 2020 13:01:29 -0500

On Mon, Jan 06, 2020 at 05:40:15PM +0000, Peter Maydell wrote:


> So we're OK to not do this because tests/iothread.c's
> main loop doesn't call g_main_loop_run(), and it doesn't
> provide an iothread_get_g_main_context() ?
> I'm kind of inclined towards being lazy and sticking with
> what this patch has, because:
>  * it matches the real iothread.c, which reduces the possiblity
>    of future surprise bugs due to things not matching up
>  * it's already been reviewed
>  * it saves me having to do a respin and retest
> But if people would prefer these bits deleted I'll stop
> being lazy :-)

Please feel free to be lazy and fix the test sooner (and that's why I
offered my r-b :).


Peter Xu

reply via email to

[Prev in Thread] Current Thread [Next in Thread]