Re: [PULL 0/7] Screendump patches

[Marc-André Lureau]

On Thu, Jan 2, 2020 at 3:55 PM Marc-André Lureau
<address@hidden> wrote:
>
> The following changes since commit dd5b0f95490883cd8bc7d070db8de70d5c979cbc:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20191219' into 
> staging (2019-12-20 16:37:07 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/elmarco/qemu.git tags/screendump-pull-request
>
> for you to fetch changes up to 6b8d2a5132378ac19cf93597dad694ea764cca4f:
>
>   screendump: use qemu_unlink() (2020-01-02 13:54:57 +0400)
>
> ----------------------------------------------------------------
> console: screendump improvements
>
> Hi,
>
> The following patches have been extracted from the "[PATCH v6 00/25]
> monitor: add asynchronous command type", as they are
> reviewable/mergeable independantly.
>
> They introduce some internal API changes, and fix
> qemu_open()/qemu_close()/unlink() misusages which should be quite
> harmless.
>
> ----------------------------------------------------------------
>
> Marc-André Lureau (7):
>   console: add graphic_hw_update_done()
>   ppm-save: pass opened fd
>   ui: add pixman image g_autoptr support
>   object: add g_autoptr support
>   screendump: replace FILE with QIOChannel and fix close()/qemu_close()
>   osdep: add qemu_unlink()
>   screendump: use qemu_unlink()
>
>  hw/display/qxl-render.c  |  9 +++--
>  hw/display/qxl.c         |  1 +
>  include/qemu/osdep.h     |  1 +
>  include/qom/object.h     |  3 ++
>  include/ui/console.h     |  2 ++
>  include/ui/qemu-pixman.h |  2 ++
>  ui/console.c             | 74 +++++++++++++++++++++-------------------
>  ui/trace-events          |  2 +-
>  util/osdep.c             | 15 ++++++++
>  9 files changed, 71 insertions(+), 38 deletions(-)
>
> --
> 2.24.0.308.g228f53135a
>
>

nack, travis found an issue:
error: unused variable

      'error' [-Werror,-Wunused-variable]

    g_autoptr(GError) error = NULL;



-- 
Marc-André Lureau