Re: [PATCH 66/86] ppc:ppc440_bamboo/sam460ex: drop RAM size fixup

[BALATON Zoltan]

On Wed, 1 Jan 2020, Philippe Mathieu-Daudé wrote:
> On 1/1/20 12:54 PM, BALATON Zoltan wrote:
> > On Tue, 31 Dec 2019, Igor Mammedov wrote:
> > > If user provided non-sense RAM size, board will complain and
> > > continue running with max RAM size supported.
> > > Also RAM is going to be allocated by generic code, so it won't be
> > > possible for board to fix things up for user.
> > >
> > > Make it error message and exit to force user fix CLI,
> > > instead of accepting non-sense CLI values.
> > >
> > > Signed-off-by: Igor Mammedov <address@hidden>
> > > ---
> > > include/hw/ppc/ppc4xx.h |  9 ++++-----
> > > hw/ppc/ppc440_bamboo.c  | 11 ++++-------
> > > hw/ppc/ppc4xx_devs.c    | 26 ++++++++++++++++----------
> > > hw/ppc/sam460ex.c       |  5 ++---
> > > 4 files changed, 26 insertions(+), 25 deletions(-)
> > >
> > > diff --git a/include/hw/ppc/ppc4xx.h b/include/hw/ppc/ppc4xx.h
> > > index 7d82259..1a28127 100644
> > > --- a/include/hw/ppc/ppc4xx.h
> > > +++ b/include/hw/ppc/ppc4xx.h
> > > @@ -42,11 +42,10 @@ enum {
> > > qemu_irq *ppcuic_init (CPUPPCState *env, qemu_irq *irqs,
> > >                        uint32_t dcr_base, int has_ssr, int has_vr);
> > >
> > > -ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks,
> > > -                               MemoryRegion ram_memories[],
> > > -                               hwaddr ram_bases[],
> > > -                               hwaddr ram_sizes[],
> > > -                               const ram_addr_t sdram_bank_sizes[]);
> > > +void ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks,
> > > +                         MemoryRegion ram_memories[],
> > > +                         hwaddr ram_bases[], hwaddr ram_sizes[],
> > > +                         const ram_addr_t sdram_bank_sizes[]);
> >
> > With this change this function does not adjust ram size any more so it may 
> > need to be renamed, e.g. ppc4xx_sdram_banks or something else.
> >
> > A better patch title may be
> >
> > ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup
>
> Or split in 2 patches.

This is mainly patching a common function used by both so I think it's OK 
to do in one patch.

Regards,
BALATON Zoltan