[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2] accel/kvm: Make "kernel_irqchip" default on
From: |
Xiaoyao Li |
Subject: |
[PATCH v2] accel/kvm: Make "kernel_irqchip" default on |
Date: |
Sat, 28 Dec 2019 18:43:26 +0800 |
Commit 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an
accelerator property") moves kernel_irqchip property from "-machine" to
"-accel kvm", but it forgets to set the default value of
kernel_irqchip_allowed and kernel_irqchip_split.
Also cleaning up the three useless members (kernel_irqchip_allowed,
kernel_irqchip_required, kernel_irqchip_split) in struct MachineState.
Fixes: 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an accelerator
property")
Reported-by: Vitaly Kuznetsov <address@hidden>
Signed-off-by: Xiaoyao Li <address@hidden>
---
Changes in v2:
- Add Reported-by tag;
- Initialize kernel_irqchip_split in init_machine();
---
accel/kvm/kvm-all.c | 3 +++
include/hw/boards.h | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index b2f1a5bcb5ef..afbbe0a1af25 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -2070,6 +2070,8 @@ static int kvm_init(MachineState *ms)
goto err;
}
+ s->kernel_irqchip_split = mc->default_kernel_irqchip_split;
+
if (s->kernel_irqchip_allowed) {
kvm_irqchip_create(s);
}
@@ -3046,6 +3048,7 @@ static void kvm_accel_instance_init(Object *obj)
KVMState *s = KVM_STATE(obj);
s->kvm_shadow_mem = -1;
+ s->kernel_irqchip_allowed = true;
}
static void kvm_accel_class_init(ObjectClass *oc, void *data)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index 61f8bb8e5a42..fb1b43d5b972 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -271,9 +271,6 @@ struct MachineState {
/*< public >*/
- bool kernel_irqchip_allowed;
- bool kernel_irqchip_required;
- bool kernel_irqchip_split;
char *dtb;
char *dumpdtb;
int phandle_start;
--
2.19.1
- [PATCH v2] accel/kvm: Make "kernel_irqchip" default on,
Xiaoyao Li <=