Re: [PATCH 03/13] hw/timer/allwinner: Remove unused definitions

[Niek Linnenbank]

On Thu, Dec 19, 2019 at 7:51 PM Philippe Mathieu-Daudé <address@hidden> wrote:

Keeping unused definition is rather confusing when reviewing.
Remove them.

Perhaps make it more clear that the definitions are unused IRQ defines?

 

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
 include/hw/timer/allwinner-a10-pit.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/hw/timer/allwinner-a10-pit.h b/include/hw/timer/allwinner-a10-pit.h
index 54c40c7db6..e4a644add9 100644
--- a/include/hw/timer/allwinner-a10-pit.h
+++ b/include/hw/timer/allwinner-a10-pit.h
@@ -10,8 +10,6 @@
 #define AW_PIT_TIMER_MAX        6

 #define AW_A10_PIT_TIMER_NR    6
-#define AW_A10_PIT_TIMER_IRQ   0x1
-#define AW_A10_PIT_WDOG_IRQ    0x100

 #define AW_A10_PIT_TIMER_IRQ_EN    0
 #define AW_A10_PIT_TIMER_IRQ_ST    0x4
--
2.21.0

Reviewed-by: Niek Linnenbank <address@hidden>

Tested-by: Niek Linnenbank <address@hidden>

--

Niek Linnenbank