[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Speed up QMP stream reading
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 0/2] Speed up QMP stream reading |
|
Date: |
Fri, 20 Dec 2019 17:09:31 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Yury Kotov <address@hidden> writes:
> Hi,
>
> This series is continuation of another one:
> [PATCH] monitor: Fix slow reading
> https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg03722.html
>
> Which also tried to read more than one byte from a stream at a time,
> but had some problems with OOB and HMP:
> https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg05018.html
>
> This series is an attempt to fix problems described.
Two problems: (1) breaks HMP migrate -d, and (2) need to think through
how this affects reading of QMP input, in particular OOB.
This series refrains from changing HMP, thus avoids (1). Good.
What about (2)? I'm feeling denser than usual today... Can you explain
real slow how QMP input works? PATCH 2 appears to splice in a ring
buffer. Why is that needed?