[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 2/4] ich9: fix getter type for sci_int property
From: |
Felipe Franciosi |
Subject: |
[PATCH v4 2/4] ich9: fix getter type for sci_int property |
Date: |
Thu, 19 Dec 2019 18:02:33 +0000 |
When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was
written using uint32_t. However, the object property is uint8_t. This
fixes the getter for correctness.
Signed-off-by: Felipe Franciosi <address@hidden>
---
hw/isa/lpc_ich9.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
index 99517c3946..9f4e00dddd 100644
--- a/hw/isa/lpc_ich9.c
+++ b/hw/isa/lpc_ich9.c
@@ -631,9 +631,7 @@ static void ich9_lpc_get_sci_int(Object *obj, Visitor *v,
const char *name,
void *opaque, Error **errp)
{
ICH9LPCState *lpc = ICH9_LPC_DEVICE(obj);
- uint32_t value = lpc->sci_gsi;
-
- visit_type_uint32(v, name, &value, errp);
+ visit_type_uint8(v, name, &lpc->sci_gsi, errp);
}
static void ich9_lpc_add_properties(ICH9LPCState *lpc)
@@ -641,7 +639,7 @@ static void ich9_lpc_add_properties(ICH9LPCState *lpc)
static const uint8_t acpi_enable_cmd = ICH9_APM_ACPI_ENABLE;
static const uint8_t acpi_disable_cmd = ICH9_APM_ACPI_DISABLE;
- object_property_add(OBJECT(lpc), ACPI_PM_PROP_SCI_INT, "uint32",
+ object_property_add(OBJECT(lpc), ACPI_PM_PROP_SCI_INT, "uint8",
ich9_lpc_get_sci_int,
NULL, NULL, NULL, NULL);
object_property_add_uint8_ptr(OBJECT(lpc), ACPI_PM_PROP_ACPI_ENABLE_CMD,
--
2.20.1
- [PATCH v4 0/4] Improve default object property_add uint helpers, Felipe Franciosi, 2019/12/19
- [PATCH v4 2/4] ich9: fix getter type for sci_int property,
Felipe Franciosi <=
- [PATCH v4 1/4] qom/object: enable setter for uint types, Felipe Franciosi, 2019/12/19
- [PATCH v4 3/4] ich9: Simplify ich9_lpc_initfn, Felipe Franciosi, 2019/12/19
- [PATCH v4 4/4] qom/object: Use common get/set uint helpers, Felipe Franciosi, 2019/12/19
- Re: [PATCH v4 0/4] Improve default object property_add uint helpers, Alexey Kardashevskiy, 2019/12/19
- Re: [PATCH v4 0/4] Improve default object property_add uint helpers, Stefan Hajnoczi, 2019/12/20
- Re: [PATCH v4 0/4] Improve default object property_add uint helpers, Marc-André Lureau, 2019/12/20