[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/30] qapi: better document NVMe blockdev @device parameter
From: |
Kevin Wolf |
Subject: |
[PULL 04/30] qapi: better document NVMe blockdev @device parameter |
Date: |
Thu, 19 Dec 2019 18:24:15 +0100 |
From: Daniel P. Berrangé <address@hidden>
Mention that this is a PCI device address & give the format it is
expected in. Also mention that it must be first unbound from any
host kernel driver.
Signed-off-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
qapi/block-core.json | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 0cf68fea14..fcb52ec24f 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2963,9 +2963,13 @@
#
# Driver specific block device options for the NVMe backend.
#
-# @device: controller address of the NVMe device.
+# @device: PCI controller address of the NVMe device in
+# format hhhh:bb:ss.f (host:bus:slot.function)
# @namespace: namespace number of the device, starting from 1.
#
+# Note that the PCI @device must have been unbound from any host
+# kernel driver before instructing QEMU to add the blockdev.
+#
# Since: 2.12
##
{ 'struct': 'BlockdevOptionsNVMe',
--
2.20.1
- [PULL 00/30] Block layer patches, Kevin Wolf, 2019/12/19
- [PULL 01/30] iotests: Provide a function for checking the creation of huge files, Kevin Wolf, 2019/12/19
- [PULL 02/30] iotests: Skip test 060 if it is not possible to create large files, Kevin Wolf, 2019/12/19
- [PULL 03/30] iotests: Skip test 079 if it is not possible to create large files, Kevin Wolf, 2019/12/19
- [PULL 04/30] qapi: better document NVMe blockdev @device parameter,
Kevin Wolf <=
- [PULL 05/30] qemu-img: fix info --backing-chain --image-opts, Kevin Wolf, 2019/12/19
- [PULL 06/30] block: Error out on image creation with conflicting size options, Kevin Wolf, 2019/12/19
- [PULL 07/30] blockjob: Fix error message for negative speed, Kevin Wolf, 2019/12/19
- [PULL 09/30] iotests: Add qemu_io_log(), Kevin Wolf, 2019/12/19
- [PULL 10/30] iotests: Fix timeout in run_job(), Kevin Wolf, 2019/12/19
- [PULL 08/30] qcow2: Declare BDRV_REQ_NO_FALLBACK supported, Kevin Wolf, 2019/12/19
- [PULL 11/30] iotests: Support job-complete in run_job(), Kevin Wolf, 2019/12/19
- [PULL 13/30] MAINTAINERS: fix qcow2-bitmap.c under Dirty Bitmaps header, Kevin Wolf, 2019/12/19
- [PULL 14/30] iotests: Add more "_require_drivers" checks to the shell-based tests, Kevin Wolf, 2019/12/19
- [PULL 15/30] iotests/273: Filter format-specific information, Kevin Wolf, 2019/12/19