Re: [RFC PATCH 4/5] !fixup "hw: arm: add Xunlong Orange Pi PC machine"

[Niek Linnenbank]

Hi Philippe,

Noted. I'll make sure mc->default_ram_size = 1 * GiB is added for the next reworked patch set v3.

Regards,

Niek

On Tue, Dec 17, 2019 at 7:27 PM Philippe Mathieu-Daudé <address@hidden> wrote:

Without this, the machine starts with default 128MB, and Ubuntu Bionic
fails:

[ ***  ] (2 of 4) A start job is running for…Persistent Storage (37s / 2min 1s)
[  *** ] (2 of 4) A start job is running for…Persistent Storage (38s / 2min 1s)
[  OK  ] Started Flush Journal to Persistent Storage.
Starting Create Volatile Files and Directories...
Starting Armbian ZRAM config...
[    **] (3 of 6) A start job is running for…s and Directories (55s / no limit)
[     *] (3 of 6) A start job is running for…s and Directories (55s / no limit)
[    **] (3 of 6) A start job is running for…s and Directories (56s / no limit)
[  OK  ] Started Create Volatile Files and Directories.
[***   ] (5 of 6) A start job is running for… ZRAM config (1min 10s / 1min 19s)
[**    ] (5 of 6) A start job is running for… ZRAM config (1min 12s / 1min 19s)
[*     ] (5 of 6) A start job is running for… ZRAM config (1min 13s / 1min 19s)
[FAILED] Failed to start Armbian ZRAM config.
See 'systemctl status armbian-zram-config.service' for details.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
 hw/arm/orangepi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm/orangepi.c b/hw/arm/orangepi.c
index 119f370924..da758d7eba 100644
--- a/hw/arm/orangepi.c
+++ b/hw/arm/orangepi.c
@@ -122,6 +122,7 @@ static void orangepi_machine_init(MachineClass *mc)
     mc->max_cpus = AW_H3_NUM_CPUS;
     mc->default_cpus = AW_H3_NUM_CPUS;
     mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a7");
+    mc->default_ram_size = 1 * GiB;
 }

 DEFINE_MACHINE("orangepi-pc", orangepi_machine_init)
--
2.21.0

--

Niek Linnenbank