[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 12/14] monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEve
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v2 12/14] monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler |
Date: |
Wed, 18 Dec 2019 18:20:07 +0100 |
The Chardev events are listed in the QEMUChrEvent enum. To be
able to use this enum in the IOEventHandler typedef, we need to
explicit an event ignored by this frontend, to silent the
following GCC warning:
CC monitor/hmp.o
monitor/hmp.c: In function ‘monitor_event’:
monitor/hmp.c:1330:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled
in switch [-Werror=switch]
1330 | switch (event) {
| ^~~~~~
cc1: all warnings being treated as errors
Acked-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
v2: Add all missing values
Cc: "Dr. David Alan Gilbert" <address@hidden>
---
monitor/hmp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/monitor/hmp.c b/monitor/hmp.c
index 8942e28933..706ebe7074 100644
--- a/monitor/hmp.c
+++ b/monitor/hmp.c
@@ -1371,6 +1371,10 @@ static void monitor_event(void *opaque, int event)
mon_refcount--;
monitor_fdsets_cleanup();
break;
+
+ case CHR_EVENT_BREAK:
+ /* Ignored */
+ break;
}
}
--
2.21.0
- [RFC PATCH v2 06/14] ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler, (continued)
- [RFC PATCH v2 06/14] ccid-card-passthru: Explicit we ignore QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 07/14] vhost-user-crypto: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 08/14] vhost-user-net: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 09/14] vhost-user-blk: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 10/14] virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 11/14] monitor/qmp: Explicit we ignore few QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [PATCH v2 12/14] monitor/hmp: Explicit we ignore a QEMUChrEvent in IOEventHandler,
Philippe Mathieu-Daudé <=
- [RFC PATCH v2 13/14] chardev/char: Explicit we ignore some QEMUChrEvent in IOEventHandler, Philippe Mathieu-Daudé, 2019/12/18
- [RFC PATCH v2 14/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef, Philippe Mathieu-Daudé, 2019/12/18
- Re: [PATCH v2 00/14] chardev: Use QEMUChrEvent enum in IOEventHandler typedef, Marc-André Lureau, 2019/12/20