[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/10] arm/arm-powerctl: rebuild hflags after setting CP15
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2 06/10] arm/arm-powerctl: rebuild hflags after setting CP15 bits in arm_set_cpu_on() |
|
Date: |
Tue, 17 Dec 2019 17:39:02 +0000 |
On Tue, 17 Dec 2019 at 16:41, Richard Henderson
<address@hidden> wrote:
>
> On 12/17/19 6:12 AM, Peter Maydell wrote:
> > Cc'ing Richard : this is one for you I think... (surely we
> > need to rebuild the hflags from scratch when we power up
> > a CPU anyway?)
>
> We do compute hflags from scratch in reset.
>
> It has also turned out that there were a few board models that poked at the
> contents of the cpu and needed special help. Some of that I would imagine
> would be fixed properly with the multi-phase reset patches, where we could
> rebuild hflags when *leaving* reset.
>
> In arm_set_cpu_on_async_work, we start by resetting the cpu and then start
> poking at the contents of some system registers. So, yes, we do need to
> rebuild after doing that. Also, I'm not sure how this function should fit
> into
> the multi-phase reset future.
>
> So:
>
> Reviewed-by: Richard Henderson <address@hidden>
Thanks; I've applied this patch to target-arm.next.
-- PMM
[PATCH v2 03/10] arm: allwinner-h3: add Clock Control Unit, Niek Linnenbank, 2019/12/16
[PATCH v2 01/10] hw: arm: add Allwinner H3 System-on-Chip, Niek Linnenbank, 2019/12/16
[PATCH v2 05/10] arm: allwinner-h3: add System Control module, Niek Linnenbank, 2019/12/16
[PATCH v2 08/10] arm: allwinner-h3: add Security Identifier device, Niek Linnenbank, 2019/12/16
[PATCH v2 07/10] arm: allwinner-h3: add CPU Configuration module, Niek Linnenbank, 2019/12/16