qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 01/28] target/xtensa: Use probe_access for itlb_hit_test


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 01/28] target/xtensa: Use probe_access for itlb_hit_test
Date: Tue, 17 Dec 2019 04:51:24 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 12/16/19 11:11 PM, Richard Henderson wrote:
We don't actually need the result of the read, only to probe that the
memory mapping exists.  This is exactly what probe_access does.

This is also the only user of any cpu_ld*_code_ra function.
Removing this allows the interface to be removed shortly.

Acked-by: Max Filippov <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
  target/xtensa/mmu_helper.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/target/xtensa/mmu_helper.c b/target/xtensa/mmu_helper.c
index f15bff306f..b01ff9399a 100644
--- a/target/xtensa/mmu_helper.c
+++ b/target/xtensa/mmu_helper.c
@@ -63,10 +63,11 @@
  void HELPER(itlb_hit_test)(CPUXtensaState *env, uint32_t vaddr)
  {
      /*
-     * Attempt the memory load; we don't care about the result but
+     * Probe the memory; we don't care about the result but
       * only the side-effects (ie any MMU or other exception)
       */
-    cpu_ldub_code_ra(env, vaddr, GETPC());
+    probe_access(env, vaddr, 1, MMU_INST_FETCH,
+                 cpu_mmu_index(env, true), GETPC());

TIL probe_access

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

  }
void HELPER(wsr_rasid)(CPUXtensaState *env, uint32_t v)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]