[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 11/16] Fix double free issue in qemu_set_log_filename().
From: |
Alex Bennée |
Subject: |
[PATCH v1 11/16] Fix double free issue in qemu_set_log_filename(). |
Date: |
Mon, 16 Dec 2019 11:07:27 +0000 |
From: Robert Foley <address@hidden>
After freeing the logfilename, we set logfilename to NULL, in case of an
error which returns without setting logfilename.
Signed-off-by: Robert Foley <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
---
util/log.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/log.c b/util/log.c
index 1ca13059eef..4316fe74eee 100644
--- a/util/log.c
+++ b/util/log.c
@@ -113,6 +113,7 @@ void qemu_set_log_filename(const char *filename, Error
**errp)
{
char *pidstr;
g_free(logfilename);
+ logfilename = NULL;
pidstr = strstr(filename, "%");
if (pidstr) {
--
2.20.1
- [PATCH v1 03/16] travis.yml: Run tcg tests with tci, (continued)
- [PATCH v1 03/16] travis.yml: Run tcg tests with tci, Alex Bennée, 2019/12/16
- [PATCH v1 04/16] iotests: Provide a function for checking the creation of huge files, Alex Bennée, 2019/12/16
- [PATCH v1 05/16] iotests: Skip test 060 if it is not possible to create large files, Alex Bennée, 2019/12/16
- [PATCH v1 06/16] iotests: Skip test 079 if it is not possible to create large files, Alex Bennée, 2019/12/16
- [PATCH v1 07/16] tests/hd-geo-test: Skip test when images can not be created, Alex Bennée, 2019/12/16
- [PATCH v1 08/16] tests/test-util-filemonitor: Skip test on non-x86 Travis containers, Alex Bennée, 2019/12/16
- [PATCH v1 10/16] ci: build out-of-tree, Alex Bennée, 2019/12/16
- [PATCH v1 11/16] Fix double free issue in qemu_set_log_filename().,
Alex Bennée <=
- [PATCH v1 09/16] travis.yml: Enable builds on arm64, ppc64le and s390x, Alex Bennée, 2019/12/16
- [PATCH v1 13/16] Add a mutex to guarantee single writer to qemu_logfile handle., Alex Bennée, 2019/12/16
- [PATCH v1 16/16] Added tests for close and change of logfile., Alex Bennée, 2019/12/16
- [PATCH v1 12/16] Cleaned up flow of code in qemu_set_log(), to simplify and clarify., Alex Bennée, 2019/12/16
- [PATCH v1 15/16] Add use of RCU for qemu_logfile., Alex Bennée, 2019/12/16
- [PATCH v1 14/16] qemu_log_lock/unlock now preserves the qemu_logfile handle., Alex Bennée, 2019/12/16