[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] qga: fence guest-set-time if hwclock not available

From: Cornelia Huck
Subject: Re: [PATCH v3] qga: fence guest-set-time if hwclock not available
Date: Tue, 10 Dec 2019 18:07:39 +0100

On Thu,  5 Dec 2019 12:53:50 +0100
Cornelia Huck <address@hidden> wrote:

> The Posix implementation of guest-set-time invokes hwclock to
> set/retrieve the time to/from the hardware clock. If hwclock
> is not available, the user is currently informed that "hwclock
> failed to set hardware clock to system time", which is quite
> misleading. This may happen e.g. on s390x, which has a different
> timekeeping concept anyway.
> Let's check for the availability of the hwclock command and
> return QERR_UNSUPPORTED for guest-set-time if it is not available.
> Reviewed-by: Laszlo Ersek <address@hidden>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
> Reviewed-by: Michael Roth <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> v2->v3:
>   - added 'static' keyword to hwclock_path
> Not sure what tree this is going through; if there's no better place,
> I can also take this through the s390 tree.
> ---
>  qga/commands-posix.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)

Queued to s390-next.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]