Re: [PATCH v2 06/18] accel: compile accel/accel.c just once

[Philippe Mathieu-Daudé]

On 12/9/19 4:01 PM, Paolo Bonzini wrote:
> Now that accel/accel.c does not use CONFIG_TCG or CONFIG_KVM anymore,
> it need not be compiled once for every softmmu target.
>
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   Makefile.objs       | 1 +
>   accel/Makefile.objs | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 11ba1a3..b6fcbac 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -55,6 +55,7 @@ common-obj-$(CONFIG_POSIX) += os-posix.o
>   
>   common-obj-$(CONFIG_LINUX) += fsdev/
>   
> +common-obj-y += accel/
>   common-obj-y += migration/
>   
>   common-obj-y += audio/
> diff --git a/accel/Makefile.objs b/accel/Makefile.objs
> index 8b498d3..17e5ac6 100644
> --- a/accel/Makefile.objs
> +++ b/accel/Makefile.objs
> @@ -1,4 +1,4 @@
> -obj-$(CONFIG_SOFTMMU) += accel.o
> +common-obj-$(CONFIG_SOFTMMU) += accel.o
>   obj-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_POSIX)) += qtest.o
>   obj-$(CONFIG_KVM) += kvm/
>   obj-$(CONFIG_TCG) += tcg/