[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size()
From: |
David Gibson |
Subject: |
Re: [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size() |
Date: |
Tue, 10 Dec 2019 14:58:56 +1100 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Mon, Dec 02, 2019 at 07:18:52PM +0100, Cédric Le Goater wrote:
> > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> > index c77f9848ec..09b3bd6443 100644
> > --- a/target/ppc/kvm.c
> > +++ b/target/ppc/kvm.c
> > @@ -2101,7 +2101,7 @@ void kvmppc_hint_smt_possible(Error **errp)
> >
> >
> > #ifdef TARGET_PPC64
> > -uint64_t kvmppc_rma_size(uint64_t current_size, unsigned int hash_shift)
> > +uint64_t kvmppc_vrma_limit(unsigned int hash_shift)
> > {
> > struct kvm_ppc_smmu_info info;
> > long rampagesize, best_page_shift;
> > @@ -2128,8 +2128,7 @@ uint64_t kvmppc_rma_size(uint64_t current_size,
> > unsigned int hash_shift)
> > }
> > }
> >
> > - return MIN(current_size,
> > - 1ULL << (best_page_shift + hash_shift - 7));
> > + return 1ULL << (best_page_shift + hash_shift - 7));
>
> The closing ')' should be removed.
Oops, that's embarrassing.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size(), Cédric Le Goater, 2019/12/02
- Re: [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size(), Greg Kurz, 2019/12/02
- Re: [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size(), Cédric Le Goater, 2019/12/02
- Re: [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size(),
David Gibson <=
- Re: [for-5.0 1/4] spapr,ppc: Simplify signature of kvmppc_rma_size(), Alexey Kardashevskiy, 2019/12/02