Re: [Qemu-devel] [PATCH v5 0/2] arm/acpi: simplify aml code and enable SHPC

[Guoheyi]

在 2019/12/6 21:50, Peter Maydell 写道:
> On Sat, 30 Nov 2019 at 03:47, Guoheyi <address@hidden> wrote:
> > Hi Peter, Igor,
> >
> > I couldn't find these 2 patches in the latest tree. Could you help to
> > merge them?
> In future I recommend pinging unapplied patches with a shorter
> delay than nine months :-)

Tha's really a long time...


> In QEMU's process, unless somebody
> has specifically said they've picked up the patch, it still
> "belongs" to the submitter to chase if it hasn't been
> applied. In this case I simply didn't see Igor's request
> that I take it -- the chances of me actually reading any
> particular list email even if it's cc'd to me are not good.

One of the reasons that I didn't check it earlier is that we don't 
really use PCI SHPC in our production version, for Linux ITS driver can 
only allocate a fixed range of MSI interrupts for a PCI-bridge during 
initialization, so a later plugged-in PCI device may not be able to get 
enough MSI interrupts and then fall back to legacy INTx. However, I 
think it is still better to let guest OS make the decision.

> I tried applying them to target-arm.next but unfortunately
> they break 'make check':
>
>    TEST    check-qtest-aarch64: tests/bios-tables-test
> acpi-test: Warning! DSDT binary file mismatch. Actual
> [aml:/tmp/aml-4IELC0], Expected [aml:tests/data/acpi/virt/DSDT].
> acpi-test: Warning! DSDT mismatch. Actual [asl:/tmp/asl-AOELC0.dsl,
> aml:/tmp/aml-4IELC0], Expected [asl:/tmp/asl-XL7KC0.dsl,
> aml:tests/data/acpi/virt/DSDT].
> **
> ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/bios-tables-test.c:477:test_acpi_asl:
> assertion failed: (all_tables_match)
> ERROR - Bail out!
> ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/tests/bios-tables-test.c:477:test_acpi_asl:
> assertion failed: (all_tables_match)
> Aborted (core dumped)
> /home/petmay01/linaro/qemu-from-laptop/qemu/tests/Makefile.include:918:
> recipe for target 'check-qtest-aarch64' failed
>
> Could you fix and resubmit, please?

Sure.


Thanks,

Heyi

> thanks
> -- PMM
>
> .