[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.0 v2 6/6] hw/pci-host: Add Kconfig entry to select the
From: |
Alex Williamson |
Subject: |
Re: [PATCH-for-5.0 v2 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge |
Date: |
Fri, 6 Dec 2019 14:38:10 -0700 |
On Fri, 6 Dec 2019 18:25:14 +0100
Philippe Mathieu-Daudé <address@hidden> wrote:
> Add the INTEL_IGD_PASSTHROUGH Kconfig option.
>
> Since it is implied by the PCI_I440FX option, this does not change
> the default selection. However users are now able to deselelect it.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/pci-host/Kconfig | 4 ++++
> hw/pci-host/Makefile.objs | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig
> index b0aa8351c4..8c88a7b9dd 100644
> --- a/hw/pci-host/Kconfig
> +++ b/hw/pci-host/Kconfig
> @@ -1,6 +1,9 @@
> config PAM
> bool
>
> +config INTEL_IGD_PASSTHROUGH
> + bool
I'd be tempted to suggest a 'depends on XEN' here and maybe use XEN in
the config name and perhaps the file name in patch 5/6 as well.
There's already confusion as to the extent that this is used
generically between both Xen and vfio assignment (it's not), so might as
well take this opportunity. Thanks,
Alex
> +
> config PREP_PCI
> bool
> select PCI
> @@ -32,6 +35,7 @@ config PCI_I440FX
> bool
> select PCI
> select PAM
> + imply INTEL_IGD_PASSTHROUGH
>
> config PCI_EXPRESS_Q35
> bool
> diff --git a/hw/pci-host/Makefile.objs b/hw/pci-host/Makefile.objs
> index 5affd21899..9dbd0f9042 100644
> --- a/hw/pci-host/Makefile.objs
> +++ b/hw/pci-host/Makefile.objs
> @@ -14,7 +14,7 @@ common-obj-$(CONFIG_VERSATILE_PCI) += versatile.o
> common-obj-$(CONFIG_PCI_SABRE) += sabre.o
> common-obj-$(CONFIG_FULONG) += bonito.o
> common-obj-$(CONFIG_PCI_I440FX) += i440fx.o
> -common-obj-$(CONFIG_PCI_I440FX) += igd_pt.o
> +common-obj-$(CONFIG_INTEL_IGD_PASSTHROUGH) += igd_pt.o
> common-obj-$(CONFIG_PCI_EXPRESS_Q35) += q35.o
> common-obj-$(CONFIG_PCI_EXPRESS_GENERIC_BRIDGE) += gpex.o
> common-obj-$(CONFIG_PCI_EXPRESS_XILINX) += xilinx-pcie.o
- [PATCH-for-5.0 v2 0/6] hw/pci-host: Add Kconfig selector for IGD PCIe pass-through, Philippe Mathieu-Daudé, 2019/12/06
- [PATCH-for-5.0 v2 1/6] hw/pci-host/i440fx: Correct the header description, Philippe Mathieu-Daudé, 2019/12/06
- [PATCH-for-5.0 v2 2/6] hw/pci-host/i440fx: Extract PCII440FXState to "hw/pci-host/i440fx.h", Philippe Mathieu-Daudé, 2019/12/06
- [PATCH-for-5.0 v2 3/6] hw/pci-host/i440fx: Use size_t to iterate over ARRAY_SIZE(), Philippe Mathieu-Daudé, 2019/12/06
- [PATCH-for-5.0 v2 5/6] hw/pci-host/i440fx: Extract the IGD Passthrough Host Bridge device, Philippe Mathieu-Daudé, 2019/12/06
- [PATCH-for-5.0 v2 4/6] hw/pci-host/i440fx: Use existing definitions instead of magic values, Philippe Mathieu-Daudé, 2019/12/06
- [PATCH-for-5.0 v2 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge, Philippe Mathieu-Daudé, 2019/12/06
- Re: [PATCH-for-5.0 v2 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge,
Alex Williamson <=