[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer
From: |
Amit Shah |
Subject: |
Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer |
Date: |
Fri, 06 Dec 2019 09:56:47 +0100 |
On Fri, 2019-12-06 at 10:17 +0800, Pan Nengyuan wrote:
> On 2019/12/6 0:45, Amit Shah wrote:
> > On Wed, 2019-12-04 at 15:31 +0800, address@hidden wrote:
> > > From: Pan Nengyuan <address@hidden>
> >
> > Shouldn't this be From: mst?
> >
> > I didn't find a ref to the original patch to confirm if you had to
> > adapt it in any way, though.
> >
>
> Here is the original
> patch:
> https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00402.html
>
> I just change one line(set used_elems to NULL). In next version, I
> will
> change function name from virtio_delete_queue to virtio_queue_cleanup
> (It's too similar between "virtio_del_queue" and
> "virtio_delete_queue"):
>
https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg00877.html
> .
>
> According to these, should I change it in next version?
Sure, please change it. Please ensure 'From:' is Michael, but in the
sign-off area, you can mention how you changed the original patch, e.g.
see the "[PMM: ...]" in
https://lore.kernel.org/qemu-devel/address@hidden/
Also, please CC me on the entire series.
Thanks,