[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/21] crypto: Fix certificate file error handling crash bug
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
Re: [PATCH 04/21] crypto: Fix certificate file error handling crash bug |
Date: |
Thu, 5 Dec 2019 15:24:08 +0000 |
30.11.2019 22:42, Markus Armbruster wrote:
> qcrypto_tls_creds_load_cert() passes uninitialized GError *gerr by
> reference to g_file_get_contents(). When g_file_get_contents() fails,
> it'll try to set a GError. Unless @gerr is null by dumb luck, this
> logs a ERROR_OVERWRITTEN_WARNING warning message and leaves @gerr
> unchanged. qcrypto_tls_creds_load_cert() then dereferences the
> uninitialized @gerr.
>
> Fix by initializing @gerr properly.
>
> Fixes: 9a2fd4347c40321f5cbb4ab4220e759fcbf87d03
> Cc: "Daniel P. Berrangé" <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> crypto/tlscredsx509.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/tlscredsx509.c b/crypto/tlscredsx509.c
> index 01fc304e5d..53a4368f49 100644
> --- a/crypto/tlscredsx509.c
> +++ b/crypto/tlscredsx509.c
> @@ -380,7 +380,7 @@ qcrypto_tls_creds_load_cert(QCryptoTLSCredsX509 *creds,
> gnutls_x509_crt_t cert = NULL;
> g_autofree char *buf = NULL;
> gsize buflen;
> - GError *gerr;
> + GError *gerr = NULL;
> int ret = -1;
> int err;
>
>
I didn't check the logic in commit message (and I don't know how GError works),
but initializing local pointer to NULL never hurts:
Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
--
Best regards,
Vladimir
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 04/21] crypto: Fix certificate file error handling crash bug,
Vladimir Sementsov-Ogievskiy <=