[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/5] virtiofsd: Get rid of unused fields in fv_QueueInfo
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v2 1/5] virtiofsd: Get rid of unused fields in fv_QueueInfo |
Date: |
Wed, 4 Dec 2019 19:42:50 +0000 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Vivek Goyal (address@hidden) wrote:
> There are some unused fields in "struct fv_QueueInfo". Get rid of these
> fields.
>
> Signed-off-by: Vivek Goyal <address@hidden>
> ---
> contrib/virtiofsd/fuse_virtio.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c
> index 31c8542b6c..2a9cd60a01 100644
> --- a/contrib/virtiofsd/fuse_virtio.c
> +++ b/contrib/virtiofsd/fuse_virtio.c
> @@ -50,12 +50,6 @@ struct fv_QueueInfo {
> int qidx;
> int kick_fd;
> int kill_fd; /* For killing the thread */
> -
> - /* The element for the command currently being processed */
> - VuVirtqElement *qe;
> - /* If any of the qe vec elements (towards vmm) are unmappable */
> - unsigned int elem_bad_in;
> - bool reply_sent;
Yep, those last two got moved into FVRequest as part of the thread pool
stuff.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> };
>
> /* A FUSE request */
> --
> 2.20.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [PATCH v2 0/5] [RFC] virtiofsd, vhost-user-fs: Add support for notification queue, Vivek Goyal, 2019/12/04
- [PATCH v2 2/5] virtiofsd: Release file locks using F_UNLCK, Vivek Goyal, 2019/12/04
- [PATCH v2 4/5] virtiofsd: Specify size of notification buffer using config space, Vivek Goyal, 2019/12/04
- [PATCH v2 3/5] virtiofd: Create a notification queue, Vivek Goyal, 2019/12/04
- [PATCH v2 1/5] virtiofsd: Get rid of unused fields in fv_QueueInfo, Vivek Goyal, 2019/12/04
- Re: [PATCH v2 1/5] virtiofsd: Get rid of unused fields in fv_QueueInfo,
Dr. David Alan Gilbert <=
- [PATCH v2 5/5] virtiofsd: Implement blocking posix locks, Vivek Goyal, 2019/12/04