[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

From: Markus Armbruster
Subject: Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument
Date: Wed, 04 Dec 2019 16:40:47 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)

Vladimir Sementsov-Ogievskiy <address@hidden> writes:

> 04.12.2019 16:03, Markus Armbruster wrote:
>> Markus Armbruster <address@hidden> writes:
>>> Vladimir Sementsov-Ogievskiy <address@hidden> writes:
>>>> 29.11.2019 17:35, Markus Armbruster wrote:
>> [...]
>>>>> I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep
>>>>> for your convenience.  The commit messages of the fixed up commits need
>>>>> rephrasing, of course.
>>>> Looked through fixups, looks OK for me, thanks! What next?
>>> Let me finish my fixing incorrect dereferences of errp, and then we
>>> figure out what to include in v7.
>> Your v6 with my fixups does not conflict with my "[PATCH v2 00/18] Error
>> handling fixes", except for "hw/core/loader-fit: fix freeing errp in
>> fit_load_fdt", which my "[PATCH v2 07/18] hw/core: Fix fit_load_fdt()
>> error handling violations" supersedes.
>> Suggest you work in the fixups and post as v7.  I'll merge that in my
>> tree, to give you a base for the remainder of your "auto propagated
>> local_err" work.  While you work on that, I'll work on getting the base
>> merged into master.  Sounds like a plan?
> Yes, that's good. I'll send v7 tomorrow.
> What you suggest to do after it?
> Send in one series a patch with macro + coccinelle +
> subset of autogenerated patches, which were reviewed (but not sending half
> a subsystem of course)?

Sounds good to me.

Visibility into the complete work is useful, though.  Having the cover
letter point to a branch in your public git repo should do.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]