Re: [PATCH 20/21] hw/intc/s390: Simplify error handling in kvm_s390_flic_realize()

[Halil Pasic]

On Mon, 2 Dec 2019 17:40:07 +0100
Cornelia Huck <address@hidden> wrote:

> On Sat, 30 Nov 2019 20:42:39 +0100
> Markus Armbruster <address@hidden> wrote:
> 
> > Cc: Halil Pasic <address@hidden>
> > Cc: Cornelia Huck <address@hidden>
> > Cc: Christian Borntraeger <address@hidden>
> > Signed-off-by: Markus Armbruster <address@hidden>
> > ---
> >  hw/intc/s390_flic_kvm.c | 10 ++++------
> >  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> Reviewed-by: Cornelia Huck <address@hidden>
> 
> ...someone else wants to take a look before I queue this?
> 

I guess it is a matter of taste.

Acked-by: Halil Pasic <address@hidden>

The only difference I can see is if the **errp argument where
to already contain an error (*errp). I guess the old code would
just keep the first error, and discard the next one, while error_setv()
does an assert(*errp == NULL).

I assume calling with *errp != NULL is not a valid scenario. But then, I
can't say I understand the use-case behind this discard the newer error
behavior of error_propagate().

Regards,
Halil