[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/4] python/qemu: New accel module and improvements

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 0/4] python/qemu: New accel module and improvements
Date: Tue, 3 Dec 2019 18:25:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 11/15/19 7:08 PM, Wainer dos Santos Moschetta wrote:
On commit abf0bf998dcb John Snow moved some code out of __init__.py
to machine.py. kvm_available() remained in though. So on patch 01
I continue his work by creating a home for that method (the new
'accel' module). Honestly I was unsure about whether move the code
to any existing module or make a new, but since I am adding more
methods related with accelerators then I thought they would
deserve a module.

The patches 02-04 introduce new helpers and make improvements. Later
I intend to use those methods on the acceptance tests such as
to automatically set the accelerator in QEMUMachine VM via Avocado
tags, and skip the test if the accelerator is not available.

  - Tree: https://github.com/wainersm/qemu
  - Branch: python_accel

  - Travis (FAIL): https://travis-ci.org/wainersm/qemu/builds/612382935
    Non-related fail due build timeout

Wainer dos Santos Moschetta (4):
   python/qemu: Move kvm_available() to its own module
   python/qemu: accel: Add list_accel() method
   python/qemu: accel: Strengthen kvm_available() checks
   python/qemu: accel: Add tcg_available() method

No more comment that what Alex said, I'd move the logging import in patch #2 where you use LOG.
With Alex comment fixed:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]