[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the Op

From: Paolo Bonzini
Subject: Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS
Date: Tue, 3 Dec 2019 14:04:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 03/12/19 10:15, Thomas Huth wrote:
>>>> Maybe we can rename this as read_boot_order_mm, and the previous
>>>> read_boot_order_pc as read_boot_order_io.
>>> I don't think it makes much sense. This was completely specific to the
>>> "prep" machine, even the "40p" machine seems to prefer fw_cfg nowadays.
>>> So let's simply remove this old stuff.
>>>> diff --git a/tests/endianness-test.c b/tests/endianness-test.c
>>>> index 58527952a5..2798802c63 100644
>>>> --- a/tests/endianness-test.c
>>>> +++ b/tests/endianness-test.c
>>>> @@ -35,7 +35,7 @@ static const TestCase test_cases[] = {
>>>>        { "mips64", "malta", 0x10000000, .bswap = true },
>>>>        { "mips64el", "fulong2e", 0x1fd00000 },
>>>>        { "ppc", "g3beige", 0xfe000000, .bswap = true, .superio =
>>>> "i82378" },
>>>> -    { "ppc", "prep", 0x80000000, .bswap = true },
>>>> +    { "ppc", "40p", 0x80000000, .bswap = true },
>> ... here you access the Super I/O behind the PCI bridge via MMIO?
> The difference is that this is an *arbitrary* address in I/O space
> there.

No, it's the base address of the ISA space, to which the tests add the
address of the pc-testdev device.  It's not any different from the
0x80000000 in boot-order-test.

That said, I think it's a sensible objection that boot order doesn't
come from m48t59 on 40p (does it not?).  The m48t59-test could also be
adjusted to test the 40p... the right way to do it would be to have an
ISA bridge driver in qgraph, but that's a topic for a separate series.



> It's not an address of a certain PCI device like the m48t59
> behind a PCI-bridge. As long as it's possible to write and read from
> this address, the test is working. Both, the "prep" and the "40p"
> machine have the "raven-pcihost" device at this address, so in this case
> the switch from "40p" to "prep" was easily possible.
>  Thomas

reply via email to

[Prev in Thread] Current Thread [Next in Thread]