[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling b
Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs
Mon, 2 Dec 2019 17:31:47 +0100
On Sat, 30 Nov 2019 20:42:36 +0100
Markus Armbruster <address@hidden> wrote:
I don't really want to restart the discussion :), but what about:
> cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(),
> qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It
> crashes when the visitor or the QOM setter fails, and its @errp
> argument is null.
"It would crash when the visitor or the QOM setter fails if its @errp
argument were NULL." ?
(Hope I got my conditionals right...)
> Messed up in commit 137974cea3 's390x/cpumodel:
I agree that "Introduced" is a bit nicer than "Messed up".
> implement QMP interface "query-cpu-model-expansion"'.
> Its three callers have the same bug. Messed up in commit 4e82ef0502
> 's390x/cpumodel: implement QMP interface "query-cpu-model-comparison"'
> and commit f1a47d08ef 's390x/cpumodel: implement QMP interface
If we agree, I can tweak the various commit messages for the s390x
patches and apply them.
> The bugs can't bite as no caller actually passes null. Fix them
> Cc: David Hildenbrand <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> target/s390x/cpu_models.c | 43 ++++++++++++++++++++++++---------------
> 1 file changed, 27 insertions(+), 16 deletions(-)
David, I don't think you gave a R-b for that one yet?
- Re: [PATCH 17/21] s390x: Fix latent query-cpu-model-FOO error handling bugs,
Cornelia Huck <=