[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/21] s390x/event-facility: Fix latent realize() error handl
From: |
David Hildenbrand |
Subject: |
Re: [PATCH 14/21] s390x/event-facility: Fix latent realize() error handling bug |
Date: |
Mon, 2 Dec 2019 10:56:31 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 30.11.19 20:42, Markus Armbruster wrote:
> sclp_events_bus_realize() crashes when object_property_set_bool()
> fails and its @errp argument is null. Messed up in commit f6102c329c
> "s390/sclp: rework sclp event facility initialization + device
> realization".
>
s/crashes .../would crash .../ ...
Reviewed-by: David Hildenbrand <address@hidden>
> The bug can't bite as no caller actually passes null. Fix it anyway.
>
> Cc: David Hildenbrand <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/s390x/event-facility.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c
> index 66205697ae..cdcf9154c4 100644
> --- a/hw/s390x/event-facility.c
> +++ b/hw/s390x/event-facility.c
> @@ -339,14 +339,16 @@ out:
>
> static void sclp_events_bus_realize(BusState *bus, Error **errp)
> {
> + Error *err = NULL;
> BusChild *kid;
>
> /* TODO: recursive realization has to be done in common code */
> QTAILQ_FOREACH(kid, &bus->children, sibling) {
> DeviceState *dev = kid->child;
>
> - object_property_set_bool(OBJECT(dev), true, "realized", errp);
> - if (*errp) {
> + object_property_set_bool(OBJECT(dev), true, "realized", &err);
> + if (errp) {
> + error_propagate(errp, err);
> return;
> }
> }
>
--
Thanks,
David / dhildenb
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 14/21] s390x/event-facility: Fix latent realize() error handling bug,
David Hildenbrand <=