[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 11/14] target/arm: default SVE length to 64 bytes for linu
Re: [PATCH v2 11/14] target/arm: default SVE length to 64 bytes for linux-user
Sun, 1 Dec 2019 18:41:34 -0800
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1
On 11/30/19 8:45 AM, Alex Bennée wrote:
> The Linux kernel chooses the default of 64 bytes for SVE registers on
> the basis that it is the largest size that won't grow the signal
> frame. When debugging larger sizes are also unwieldy in gdb as each
> zreg will take over a page of terminal to display.
> The user can of course always specify a larger size with the
> sve-max-vq property on the command line:
> -cpu max,sve-max-vq=16
> This should not make any difference to SVE enabled software as the SVE
> is of course vector length agnostic.
> Signed-off-by: Alex Bennée <address@hidden>
> target/arm/cpu64.c | 3 +++
> 1 file changed, 3 insertions(+)
6 is the largest size that doesn't grow the signal frame.
I imagine 4 was chosen because that's the only real hw atm.
> + /* Default sve-max-vq to a reasonable numer */
> + cpu->sve_max_vq = 4;
I also agree that we should match the kernel, but this is not the right way.
Changing max vq is not the same as changing the default vq.
You should change the value of env->vfp.zcr_el in arm_cpu_reset(), and the
user can increase the length with prctl(2) as they would be able to on real
hardware that would have support for longer vector lengths.
Also, I don't think you should mix this up with gdb stuff.
- Re: [PATCH v2 11/14] target/arm: default SVE length to 64 bytes for linux-user,
Richard Henderson <=