qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 19/21] error: Clean up unusual names of Error * variables


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 19/21] error: Clean up unusual names of Error * variables
Date: Sat, 30 Nov 2019 21:03:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1

On 11/30/19 8:42 PM, Markus Armbruster wrote:
Local Error * variables are conventionally named @err or @local_err,
and Error ** parameters @errp.  Naming local variables like parameters
is confusing.  Clean that up.

Naming parameters like local variables is also confusing.  Left for
another day.

Signed-off-by: Markus Armbruster <address@hidden>
---
  hw/intc/s390_flic_kvm.c    | 10 +++++-----
  hw/ppc/spapr_pci.c         | 16 ++++++++--------
  hw/ppc/spapr_pci_nvlink2.c | 10 +++++-----
  tests/test-blockjob.c      | 16 ++++++++--------
  4 files changed, 26 insertions(+), 26 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]