[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v6] backends/cryptodev: drop local_err from cryptodev_backend_complete() |
Date: |
Fri, 29 Nov 2019 07:10:55 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Vladimir Sementsov-Ogievskiy <address@hidden> writes:
> No reason for local_err here, use errp directly instead.
Related: "[PATCH v6] hw/vfio/ap: drop local_err from vfio_ap_realize".
I'm surprised it's just two. Did you search for the anti-pattern
systematically?
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
> ---
>
> v6: add r-b by Philippe and Marc-André
>
> backends/cryptodev.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/backends/cryptodev.c b/backends/cryptodev.c
> index 3c071eab95..5a9735684e 100644
> --- a/backends/cryptodev.c
> +++ b/backends/cryptodev.c
> @@ -176,19 +176,10 @@ cryptodev_backend_complete(UserCreatable *uc, Error
> **errp)
> {
> CryptoDevBackend *backend = CRYPTODEV_BACKEND(uc);
> CryptoDevBackendClass *bc = CRYPTODEV_BACKEND_GET_CLASS(uc);
> - Error *local_err = NULL;
>
> if (bc->init) {
> - bc->init(backend, &local_err);
> - if (local_err) {
> - goto out;
> - }
> + bc->init(backend, errp);
> }
> -
> - return;
> -
> -out:
> - error_propagate(errp, local_err);
> }
>
> void cryptodev_backend_set_used(CryptoDevBackend *backend, bool used)
Reviewed-by: Markus Armbruster <address@hidden>