Re: [PATCH v37 00/17] QEMU AVR 8 bit cores

[Aleksandar Markovic]

On Thursday, November 28, 2019, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 11/28/19 2:46 PM, Michael Rolnik wrote:
> > I will rename them.
>
> Please wait comments from Richard before a version respin.

Everything went well last 10 or so days, Michael and Sarah were responsive, the code and series got slowly improved more and more, but there was this disruption by your idea to "take over" the series with implementation of "real boards", rather than leave Michael doing improvements by himself, based on our feedback, like in a regular process of review... There are some pending quite reasonable and simple review items from me, Michael should continue working on them... But now he is told to wait... Shouldn't it be some better way?

> > On Thu, Nov 28, 2019 at 3:41 PM Aleksandar Markovic <address@hidden <mailto:aleksandar.m.mail@gmail.com>> wrote:
> [...]
> >         If I understand Aleksandar correctly, the naming is incorrect
> >         because too generic to AVR family, why Sarah only modeled the
> >         Atmel implementation.
> >
> >         Renaming devices such hw/char/avr_usart.c ->
> >         hw/char/atmel_usart.c (similarly with the macros) would be
> >         enough Aleksandar?
> >
> >
> >
> >     Some renaming could help, perhaps not quite like the one above, but
> >     my point (which I find hard to believe I can't explain to you) is
> >     that peripherals inside the chip evolved over time, as starkly
> >     opposed to external peripherals that are set in stone...