[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/15] s390x: protvirt: Disable address checks for PV guest I
|
From: |
Janosch Frank |
|
Subject: |
Re: [PATCH 14/15] s390x: protvirt: Disable address checks for PV guest IO emulation |
|
Date: |
Thu, 28 Nov 2019 17:24:49 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 11/28/19 5:18 PM, Cornelia Huck wrote:
> On Thu, 28 Nov 2019 17:10:38 +0100
> Janosch Frank <address@hidden> wrote:
>
>> On 11/28/19 4:28 PM, Thomas Huth wrote:
>
>>> Would it make sense to hide all these changes in decode_basedisp_s()
>>> instead? ... so that decode_basedisp_s() returns 0 if env->pv == true ?
>>> ... or are there still cases where we need real values from
>>> decode_basedisp_s() in case of env->pv==true?
>>
>> I'd like to keep decode_basedisp_s() as is, but how about a static
>> function in ioinst.c called something like get_address_from_regs()?
>>
>> It'll call decode_basedisp_s() or return 0.
>
> We could do something like that; but do we ever get there for other
> instruction formats as well? It feels a bit odd to single out this one.
>
sclp is rre (register address) and diag308 is rs-a (r1 is the address).
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 09/15] s390x: protvirt: SCLP interpretation, (continued)
[PATCH 12/15] s390x: protvirt: Set guest IPL PSW, Janosch Frank, 2019/11/20
[PATCH 14/15] s390x: protvirt: Disable address checks for PV guest IO emulation, Janosch Frank, 2019/11/20
[PATCH 10/15] s390x: protvirt: Add new VCPU reset functions, Janosch Frank, 2019/11/20
[PATCH 13/15] s390x: protvirt: Move diag 308 data over SIDAD, Janosch Frank, 2019/11/20
[PATCH 15/15] s390x: protvirt: Handle SIGP store status correctly, Janosch Frank, 2019/11/20