[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-h
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c |
|
Date: |
Wed, 27 Nov 2019 08:50:31 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Maxim Levitsky <address@hidden> writes:
> Signed-off-by: Maxim Levitsky <address@hidden>
> ---
> blockdev-hmp-cmds.c | 97 ++++++++++++++++++++++++++++++++++++++++++++-
> blockdev.c | 95 --------------------------------------------
> 2 files changed, 96 insertions(+), 96 deletions(-)
hmp_drive_add() and hmp_drive_del() are now in the same .c, which feels
right. Their declarations are still in separate .h. Suggest to move
hmp_drive_add() from sysemu/sysemu.h to sysemu/blockdev.h. Or maybe
create a separate .h for the block HMP stuff, just like you created a
separate .c.
- [PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups, Maxim Levitsky, 2019/11/20
- [PATCH 1/9] monitor: uninline add_init_drive, Maxim Levitsky, 2019/11/20
- [PATCH 3/9] monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 2/9] monitor: rename device-hotplug.c to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 5/9] monitor: move hmp_block_job* to blockdev-hmp-cmd.c, Maxim Levitsky, 2019/11/20
- [PATCH 4/9] monitor: move hmp_drive_mirror and hmp_drive_backup to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 6/9] monitor: move hmp_snapshot_* to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 7/9] monitor: move remaining hmp_block* functions to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 9/9] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands, Maxim Levitsky, 2019/11/20