[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] blockjob: Fix error message for negative speed
From: |
Kevin Wolf |
Subject: |
[PATCH] blockjob: Fix error message for negative speed |
Date: |
Tue, 26 Nov 2019 14:42:22 +0100 |
The error message for a negative speed uses QERR_INVALID_PARAMETER,
which implies that the 'speed' option doesn't even exist:
{"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}}
Make it use QERR_INVALID_PARAMETER_VALUE instead:
{"error": {"class": "GenericError", "desc": "Parameter 'speed' expects a
non-negative value"}}
Signed-off-by: Kevin Wolf <address@hidden>
---
blockjob.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/blockjob.c b/blockjob.c
index c6e20e2fcd..5d63b1e89d 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -261,7 +261,8 @@ void block_job_set_speed(BlockJob *job, int64_t speed,
Error **errp)
return;
}
if (speed < 0) {
- error_setg(errp, QERR_INVALID_PARAMETER, "speed");
+ error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "speed",
+ "a non-negative value");
return;
}
--
2.20.1
- [PATCH] blockjob: Fix error message for negative speed,
Kevin Wolf <=