[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 0/4] Improve default object property_add uint helpers
From: |
Felipe Franciosi |
Subject: |
[PATCH 0/4] Improve default object property_add uint helpers |
Date: |
Mon, 25 Nov 2019 15:36:34 +0000 |
This improves the family of object_property_add_uintXX_ptr helpers by enabling
a default setter when desired. To prevent an API behavioural change (from
clients that already used these helpers and did not want a setter), we add a
"readonly" parameter that allow clients to only have a getter. Patch 1 enhances
the API and modify current users.
While modifying the clients of the API, a couple of improvement opportunities
were observed in ich9. These were added in separate patches (2 and 3).
Patch 3 cleans up a lot of existing code by moving various objects to the
enhanced API. Previously, those objects had their own getters/setters that only
updated the values without further checks. Some of them actually lacked a check
for setting overflows, which could have resulted in undesired values being set.
The new default setters include a check for that, not updating the values in
case of errors (and propagating them).
Felipe Franciosi (4):
qom/object: enable setter for uint types
ich9: fix getter type for sci_int property
ich9: Simplify ich9_lpc_initfn
qom/object: Use common get/set uint helpers
hw/acpi/ich9.c | 97 +++------------------------
hw/acpi/pcihp.c | 6 +-
hw/acpi/piix4.c | 12 ++--
hw/isa/lpc_ich9.c | 31 +++------
hw/misc/edu.c | 12 +---
hw/pci-host/q35.c | 14 +---
hw/ppc/spapr.c | 17 +----
hw/ppc/spapr_drc.c | 2 +-
hw/vfio/pci-quirks.c | 18 ++---
include/qom/object.h | 28 +++++---
memory.c | 15 +----
qom/object.c | 152 ++++++++++++++++++++++++++++++++++++-------
target/arm/cpu.c | 21 +-----
target/i386/sev.c | 102 ++---------------------------
ui/console.c | 3 +-
15 files changed, 196 insertions(+), 334 deletions(-)
--
2.20.1
- [PATCH 0/4] Improve default object property_add uint helpers,
Felipe Franciosi <=
[PATCH 3/4] ich9: Simplify ich9_lpc_initfn, Felipe Franciosi, 2019/11/25