[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suff
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list |
|
Date: |
Mon, 25 Nov 2019 09:15:31 -0300 |
On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote:
> Tao Xu <address@hidden> writes:
>
> > Add do_strtomul() to convert string according to different suffixes.
> >
> > Reviewed-by: Eduardo Habkost <address@hidden>
> > Signed-off-by: Tao Xu <address@hidden>
>
> What's the actual change here? "Refactor" suggests the interfaces stay
> the same, only their implementation changes. "Support suffixes list"
> suggests some interface supports something new.
1) Parameters added to suffix_mul() (suffix table);
2) do_strtomul() is being extracted from do_strtosz().
do_strtomul() interface and behavior stays the same.
--
Eduardo
Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list, Markus Armbruster, 2019/11/26
[PATCH v17 01/14] util/cutils: Add Add qemu_strtold and qemu_strtold_finite, Tao Xu, 2019/11/22