[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups |
Date: |
Fri, 22 Nov 2019 10:15:28 +0000 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
* Maxim Levitsky (address@hidden) wrote:
> This patch series is bunch of cleanups
> to the hmp monitor code.
>
> This series only touched blockdev related hmp handlers.
Hi Maxim,
This looks mostly OK to me from the HMP side - with one change;
can you please move the blockdev-hmp-cmds.c into either monitor/ or
block/; with that
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
we also need a corresponding review by a block person.
Dave
> No functional changes expected other that
> light error message changes by the last patch.
>
> This was inspired by this bugzilla:
> https://bugzilla.redhat.com/show_bug.cgi?id=1719169
>
> Basically some users still parse hmp error messages,
> and they would like to have them prefixed with 'Error:'
>
> In commit 66363e9a43f649360a3f74d2805c9f864da027eb we added
> the hmp_handle_error which does exactl that but some hmp handlers
> don't use it.
>
> In this patch series, I moved all the block related hmp handlers
> into blockdev-hmp-cmds.c, and then made them use this function
> to report the errors.
>
> I hope I didn't change too much code, I just felt that if
> I touch this code, I can also make it easier to find these
> handlers, that were scattered over 3 different files.
>
> Best regards,
> Maxim Levitsky
>
> Maxim Levitsky (9):
> monitor: uninline add_init_drive
> monitor: rename device-hotplug.c to blockdev-hmp-cmds.c
> monitor: move hmp_drive_del and hmp_commit to blockdev-hmp-cmds.c
> monitor: move hmp_drive_mirror and hmp_drive_backup to
> blockdev-hmp-cmds.c
> monitor: move hmp_block_job* to blockdev-hmp-cmd.c
> monitor: move hmp_snapshot_* to blockdev-hmp-cmds.c
> monitor: move remaining hmp_block* functions to blockdev-hmp-cmds.c
> monitor: move hmp_info_block* to blockdev-hmp-cmds.c
> monitor/hmp: Prefer to use hmp_handle_error for error reporting in
> block hmp commands
>
> MAINTAINERS | 1 +
> Makefile.objs | 4 +-
> blockdev-hmp-cmds.c | 656 ++++++++++++++++++++++++++++++++++++++++++++
> blockdev.c | 95 -------
> device-hotplug.c | 91 ------
> monitor/hmp-cmds.c | 465 -------------------------------
> 6 files changed, 659 insertions(+), 653 deletions(-)
> create mode 100644 blockdev-hmp-cmds.c
> delete mode 100644 device-hotplug.c
>
> --
> 2.17.2
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [PATCH 5/9] monitor: move hmp_block_job* to blockdev-hmp-cmd.c, (continued)
- [PATCH 5/9] monitor: move hmp_block_job* to blockdev-hmp-cmd.c, Maxim Levitsky, 2019/11/20
- [PATCH 4/9] monitor: move hmp_drive_mirror and hmp_drive_backup to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 8/9] monitor: move hmp_info_block* to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 6/9] monitor: move hmp_snapshot_* to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 7/9] monitor: move remaining hmp_block* functions to blockdev-hmp-cmds.c, Maxim Levitsky, 2019/11/20
- [PATCH 9/9] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands, Maxim Levitsky, 2019/11/20
- Re: [PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups,
Dr. David Alan Gilbert <=