Re: [PATCH 0/5] hvf: stability fixes for HVF

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/5] hvf: stability fixes for HVF
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
e1d1679 hvf: save away type as well as vector so we can reinject them
b201a1b hvf: more accurately match SDM when setting CR0 and PDPTE registers
995bd07 hvf: correctly handle REX prefix in relation to legacy prefixes
3ebb7cf hvf: remove TSC synchronization code because it isn't fully complete
5a99e4f hvf: non-RAM, non-ROMD memory ranges are now correctly mapped in

=== OUTPUT BEGIN ===
1/5 Checking commit 5a99e4fc4643 (hvf: non-RAM, non-ROMD memory ranges are now 
correctly mapped in)
WARNING: Block comments use a leading /* on a separate line
#72: FILE: target/i386/hvf/hvf.c:171:
+            /* If the memory device is not in romd_mode, then we actually want

WARNING: Block comments use a trailing */ on a separate line
#73: FILE: target/i386/hvf/hvf.c:172:
+             * to remove the hvf memory slot so all accesses will trap. */

ERROR: Error messages should not contain newlines
#92: FILE: target/i386/hvf/hvf.c:194:
+            error_report("Failed to reset overlapping slot\n");

WARNING: line over 80 characters
#100: FILE: target/i386/hvf/hvf.c:203:
+    if (area->readonly || (!memory_region_is_ram(area) && 
memory_region_is_romd(area)))

ERROR: braces {} are necessary for all arms of this statement
#100: FILE: target/i386/hvf/hvf.c:203:
+    if (area->readonly || (!memory_region_is_ram(area) && 
memory_region_is_romd(area)))
[...]
+    else
[...]

ERROR: Error messages should not contain newlines
#115: FILE: target/i386/hvf/hvf.c:229:
+        error_report("Error registering new memory slot\n");

ERROR: braces {} are necessary for all arms of this statement
#124: FILE: target/i386/hvf/hvf.c:357:
+    if (!slot)
[...]

ERROR: line over 90 characters
#126: FILE: target/i386/hvf/hvf.c:359:
+    if (!memory_region_is_ram(slot->region) && !(read && 
memory_region_is_romd(slot->region)))

ERROR: braces {} are necessary for all arms of this statement
#126: FILE: target/i386/hvf/hvf.c:359:
+    if (!memory_region_is_ram(slot->region) && !(read && 
memory_region_is_romd(slot->region)))
[...]

total: 6 errors, 3 warnings, 128 lines checked

Patch 1/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/5 Checking commit 3ebb7cf4ab7f (hvf: remove TSC synchronization code because 
it isn't fully complete)
3/5 Checking commit 995bd07ed756 (hvf: correctly handle REX prefix in relation 
to legacy prefixes)
WARNING: line over 80 characters
#34: FILE: target/i386/hvf/x86_decode.c:1691:
+target_ulong get_reg_ref(CPUX86State *env, int reg, int rex_present, int 
is_extended,

WARNING: line over 80 characters
#65: FILE: target/i386/hvf/x86_decode.c:1715:
+target_ulong get_reg_val(CPUX86State *env, int reg, int rex_present, int 
is_extended,

WARNING: line over 80 characters
#70: FILE: target/i386/hvf/x86_decode.c:1719:
+    memcpy(&val, (void *)get_reg_ref(env, reg, rex_present, is_extended, 
size), size);

WARNING: line over 80 characters
#78: FILE: target/i386/hvf/x86_decode.c:1852:
+        /* REX prefix must come after legacy prefixes.  REX before legacy is 
ignored.

WARNING: Block comments use a leading /* on a separate line
#78: FILE: target/i386/hvf/x86_decode.c:1852:
+        /* REX prefix must come after legacy prefixes.  REX before legacy is 
ignored.

WARNING: Block comments use * on subsequent lines
#79: FILE: target/i386/hvf/x86_decode.c:1853:
+        /* REX prefix must come after legacy prefixes.  REX before legacy is 
ignored.
+           Clear rex to simulate this. */

WARNING: Block comments use a trailing */ on a separate line
#79: FILE: target/i386/hvf/x86_decode.c:1853:
+           Clear rex to simulate this. */

WARNING: line over 80 characters
#192: FILE: target/i386/hvf/x86_decode.h:306:
+target_ulong get_reg_ref(CPUX86State *env, int reg, int rex_present, int 
is_extended,

WARNING: line over 80 characters
#195: FILE: target/i386/hvf/x86_decode.h:308:
+target_ulong get_reg_val(CPUX86State *env, int reg, int rex_present, int 
is_extended,

total: 0 errors, 9 warnings, 169 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit b201a1b3b822 (hvf: more accurately match SDM when setting 
CR0 and PDPTE registers)
5/5 Checking commit e1d16795b97a (hvf: save away type as well as vector so we 
can reinject them)
WARNING: line over 80 characters
#25: FILE: target/i386/hvf/hvf.c:637:
+            /* Save away the event type as well so we can inject the correct 
type. */

ERROR: line over 90 characters
#26: FILE: target/i386/hvf/hvf.c:638:
+            env->interrupt_injected = idtvec_info & (VMCS_IDT_VEC_TYPE | 
VMCS_IDT_VEC_VECNUM);

WARNING: line over 80 characters
#34: FILE: target/i386/hvf/hvf.c:645:
+            /* Save away the event type as well so we can inject the correct 
type. */

WARNING: line over 80 characters
#35: FILE: target/i386/hvf/hvf.c:646:
+            env->exception_nr = idtvec_info & (VMCS_IDT_VEC_TYPE | 
VMCS_IDT_VEC_VECNUM);

WARNING: line over 80 characters
#108: FILE: target/i386/hvf/x86hvf.c:389:
+                /* Make sure to indicate that VMCS_ENTRY_EXCEPTION_ERROR is 
valid */

total: 1 errors, 4 warnings, 91 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden