Re: [PATCH v2] linux-user/strace: Add missing signal strings

[Aleksandar Markovic]

On Thu, Nov 21, 2019 at 6:27 PM Laurent Vivier <address@hidden> wrote:
>
> Le 20/11/2019 à 15:55, Helge Deller a écrit :
> > Add the textual representations of some missing target signals.
> >
> > Signed-off-by: Helge Deller <address@hidden>
> >
> > diff --git a/linux-user/strace.c b/linux-user/strace.c
> > index 3d4d684450..de43238fa4 100644
> > --- a/linux-user/strace.c
> > +++ b/linux-user/strace.c
> > @@ -146,6 +146,19 @@ print_signal(abi_ulong arg, int last)
> >      case TARGET_SIGSTOP: signal_name = "SIGSTOP"; break;
> >      case TARGET_SIGTTIN: signal_name = "SIGTTIN"; break;
> >      case TARGET_SIGTTOU: signal_name = "SIGTTOU"; break;
> > +    case TARGET_SIGIO: signal_name = "SIGIO"; break;
> > +    case TARGET_SIGBUS: signal_name = "SIGBUS"; break;
> > +    case TARGET_SIGPWR: signal_name = "SIGPWR"; break;
> > +    case TARGET_SIGURG: signal_name = "SIGURG"; break;
> > +    case TARGET_SIGSYS: signal_name = "SIGSYS"; break;
> > +    case TARGET_SIGTRAP: signal_name = "SIGTRAP"; break;
> > +    case TARGET_SIGXCPU: signal_name = "SIGXCPU"; break;
> > +    case TARGET_SIGPROF: signal_name = "SIGPROF"; break;
> > +    case TARGET_SIGTSTP: signal_name = "SIGTSTP"; break;
> > +    case TARGET_SIGXFSZ: signal_name = "SIGXFSZ"; break;
> > +    case TARGET_SIGWINCH: signal_name = "SIGWINCH"; break;
> > +    case TARGET_SIGVTALRM: signal_name = "SIGVTALRM"; break;
> > +    case TARGET_SIGSTKFLT: signal_name = "SIGSTKFLT"; break;
> >      }
> >      if (signal_name == NULL) {
> >          print_raw_param("%ld", arg, last);
> >
>
> Reviewed-by: Laurent Vivier <address@hidden>
>

Laurent, I have a significant objection over this patch (in this
form). Please read my response in this thread.

Thanks,
Aleksandar